command: Providers schema shows required_providers#26318
Merged
Conversation
Codecov Report
|
alisdair
force-pushed
the
alisdair/providers-schema-required-providers
branch
from
7191700 to
d079957
Compare
jbardin
approved these changes
Sep 22, 2020
The providers schema command is using the Config.ProviderTypes method, which had not been kept up to date with the changes to provider requirements detection made in Config.ProviderRequirements. This resulted in any currently-unused providers being omitted from the output. This commit changes the ProviderTypes method to use the same underlying logic as ProviderRequirements, which ensures that `required_providers` blocks are taken into account. Includes an integration test case to verify that this fixes the provider schemas command bug.
alisdair
force-pushed
the
alisdair/providers-schema-required-providers
branch
from
d079957 to
18f9ea5
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The providers schema command is using the
Config.ProviderTypesmethod, which had not been kept up to date with the changes to provider requirements detection made inConfig.ProviderRequirements. This resulted in any currently-unused providers being omitted from the output.This commit changes the
ProviderTypesmethod to use the same underlying logic asProviderRequirements, which ensures thatrequired_providersblocks are taken into account.Includes an integration test case to verify that this fixes the provider schemas command bug.
Fixes #26306. Diff best viewed ignoring whitespace, due to the new nil check if statement.